-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pine] Support PineTopper
as a component of distkv ecosystem.
#520
Conversation
Can We add an method called like getMemberInfo. v = topper.getMemberInfo("hello");
print( v. getRank() );
print( v. getScore() ); |
PineTopper
as a component of distkv ecosystem.PineTopper
as a component of distkv ecosystem.
PineTopper
as a component of distkv ecosystem.PineTopper
as a component of distkv ecosystem.
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
============================================
+ Coverage 52.33% 52.42% +0.09%
Complexity 47 47
============================================
Files 109 109
Lines 3342 3357 +15
Branches 212 213 +1
============================================
+ Hits 1749 1760 +11
- Misses 1457 1458 +1
- Partials 136 139 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
=========================================
Coverage 52.42% 52.42%
Complexity 47 47
=========================================
Files 109 109
Lines 3357 3357
Branches 213 213
=========================================
Hits 1760 1760
Misses 1458 1458
Partials 139 139
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look Good OverAll
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
Introduction
As discussed before, we'd like to support a feature named
Pine
as the ecosystem of Distkv. ThePine
is a set of useful components for Web application that helps Web developer develop simpley.This PR supports the
PineTopper
component as the ranking list.Usage of this PR
The usage or API of
PineTopper
looks like:The related issue is #279