Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deactive namespace method #521

Merged
merged 2 commits into from
Feb 18, 2020
Merged

Conversation

kairbon
Copy link
Collaborator

@kairbon kairbon commented Feb 18, 2020

this close #522

@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #521 into master will increase coverage by 0.09%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #521      +/-   ##
============================================
+ Coverage     52.19%   52.29%   +0.09%     
- Complexity      177      182       +5     
============================================
  Files           103      103              
  Lines          3276     3291      +15     
  Branches        210      211       +1     
============================================
+ Hits           1710     1721      +11     
- Misses         1431     1432       +1     
- Partials        135      138       +3
Impacted Files Coverage Δ Complexity Δ
.../client/commandlinetool/DistkvCommandExecutor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ava/com/distkv/asyncclient/DefaultAsyncClient.java 87.09% <100%> (+0.88%) 10 <1> (+1) ⬆️
...ava/com/distkv/namespace/NamespaceInterceptor.java 100% <100%> (ø) 4 <1> (+1) ⬆️
...in/java/com/distkv/client/DefaultDistkvClient.java 90.9% <100%> (+5.9%) 10 <1> (+2) ⬆️
...client/commandlinetool/CommandExecutorHandler.java 76.49% <50%> (-0.41%) 41 <1> (+1)
...n/java/com/distkv/parser/DistkvNewSqlListener.java 81.06% <50%> (-0.31%) 0 <0> (ø)

@ou-taku14
Copy link
Member

Is there a problem with active Namespace operations multiple times?

@jovany-wang jovany-wang added the new feature new features label Feb 18, 2020
Copy link
Member

@ou-taku14 ou-taku14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM~

@jovany-wang jovany-wang merged commit df66c5b into distkv-project:master Feb 18, 2020
@kairbon kairbon deleted the apr branch March 23, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deactive namespace method for client
3 participants