Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running CMake modifies projects/readme.md #16

Closed
brobeson opened this issue Jun 3, 2017 · 1 comment · Fixed by #44
Closed

Running CMake modifies projects/readme.md #16

brobeson opened this issue Jun 3, 2017 · 1 comment · Fixed by #44
Assignees
Labels
Milestone

Comments

@brobeson
Copy link
Contributor

brobeson commented Jun 3, 2017

For some reason, when I run CMake from a clean build directory, projects/readme.md in the repository is modified. Thus, I end up building a "dirtyrepo" version.

This occurred trying to build 17.05.2.

A work around is to

  1. Run CMake
  2. git checkout -- .
  3. Run CMake again.

However, I don't think this should be occurring at all.

@brobeson brobeson added the bug label Jun 3, 2017
@brobeson brobeson changed the title Running CMake modifies readme.md Running CMake modifies projects/readme.md Jun 3, 2017
@brobeson brobeson self-assigned this Jul 16, 2017
@smanders
Copy link
Contributor

smanders commented Jan 23, 2018

the projects/README.md shouldn't be modified by hand -- it is generated at cmake-time and is populated by the contents of the projects/*.cmake files -- if there are mods (and a dirtyrepo is built) then a developer has manually added something to the README and this should be avoided!


CPPZMQ

+++ cmake
--- repo
+|[CPPZMQ](https://github.com/zeromq/cppzmq 'CPPZMQ')|[MIT](https://github.com/zeromq/cppzmq/blob/v4.2.1/LICENSE 'MIT')|CPPZMQ is a minimal c++ binding to the libzmq functions.|4.2.1|none|none|
-|[cppzmq](https://github.com/zeromq/cppzmq/tree/v4.2.1 'cppzmq')|[MIT](https://github.com/zeromq/cppzmq/blob/v4.2.1/LICENSE 'MIT')|cppzmq is a c++ header containing the zeromq cbindings|4.2.1|[repo](https://github.com/zeromq/cppzmq/blob/v4.2.1)|none|

HDF-GROUP

+++ cmake
--- repo
+|[HDF-GROUP](http://www.hdfgroup.org 'The HDF Group')|[open](https://www.hdfgroup.org/ftp/HDF5/current/src/unpacked/COPYING 'HDF5 License')|HDF5 is a data model, library, and file format for storing and managing data|1.8.16|none|none|
-|[HDF-GROUP](http://www.hdfgroup.org 'The HDF Group')|[open](https://www.hdfgroup.org/ftp/HDF5/current/src/unpacked/COPYING 'HDF5 License')|HDF5 is a data model, library, and file format for storing and managing data|1.8.16|none|[diff](https://github.com/distributePro/ovsrpro/blob/master/patches/hdf5.patch 'patch/diff')|

Kerberos

+++ cmake
--- repo
-|[Kerberos](http://web.mit.edu/kerberos/ 'Kerberos')|[open](http://web.mit.edu/kerberos/krb5-1.14/doc/mitK5license.html 'MIT Kerberos License information')|Kerberos is a network authentication protocol (only built on Windows)|5.1.14|none|none|
  • PRO_KERBEROS shouldn't be inside if(WIN32) -- if you only build this project on Windows the conditional should only be in the build_kerberos function, every other step (download, mkpatch, patch) should be done on every platform

librdkafka

+++ cmake
--- repo
+|[librdkafka](https://github.com/edenhill/librdkafka 'librdkafka on github')|[open](https://github.com/edenhill/librdkafka/blob/master/LICENSE '2-clause BSD license')|librdkafka is a C library implementation of the Apache Kafka protocol, containing both Producer and Consumer support|v0.9.5|[repo](https://github.com/distributePro/librdkafka 'distributePro fork of librdkafka repo on github')|[diff](https://github.com/distributePro/librdkafka/compare/edenhill:v0.9.5...xp-v0.9.5 'patch/diff')|
-|[librdkafka](https://github.com/edenhill/librdkafka 'librdkafka on github')|[open](https://github.com/edenhill/librdkafka/blob/master/LICENSE '2-clause BSD license')|librdkafka is a C library implementation of the Apache Kafka protocol, containing both Producer and Consumer support|0.9.5|[repo](https://github.com/distributePro/librdkafka 'distributePro fork of librdkafka repo on github')|[diff](https://github.com/distributePro/librdkafka/compare/edenhill:v0.9.5...xp-v0.9.5 'patch/diff') [win-diff](https://github.com/distributePro/ovsrpro/blob/master/patches/librdkafka-windows.patch 'patch/diff (Windows only)')|
  • VER is defined in projects/librdkafka.cmake as v0.9.5 and someone hard-coded the README.md to be 0.9.5
  • manually added win-diff

NOVAS

+++ cmake
--- repo
+|[NOVAS](http://aa.usno.navy.mil/software/novas/novas_info.php 'NOVAS')|[open](http://aa.usno.navy.mil/software/novas/novas_c/README.txt '(See Section IV. Using NOVAS in Your Applications)')|NOVAS is an integrated package of ANSI C functions for computing many commonly needed quantities in positional astronomy.|3.1|none|none|
-|[NOVAS](http://aa.usno.navy.mil/software/novas/novas_info.php 'NOVAS')|[open](http://aa.usno.navy.mil/software/novas/novas_c/README.txt '(See Section IV. Using NOVAS in Your Applications)')|NOVAS is an integrated package of ANSI C functions for computing many commonly needed quantities in positional astronomy.|3.1|none|[diff](https://github.com/distributePro/ovsrpro/blob/master/patches/novas.patch 'patch/diff')|

Qt

+++ cmake
--- repo
+|[Qt](http://qt.io/ 'Qt - Home')|[LGPL](http://www.qt.io/qt-licensing-terms/ 'LGPL')|One Qt Code: Create Powerful Applications & Devices|5.8.0|[repo](http://code.qt.io/cgit/qt/qt5.git 'Qt5 main repo')|none|
-|[Qt](http://qt.io/ 'Qt - Home')|[LGPL](http://www.qt.io/qt-licensing-terms/ 'LGPL')|One Qt Code: Create Powerful Applications & Devices|5.8.0|[repo](http://code.qt.io/cgit/qt/qt5.git 'Qt5 main repo')|[diff](https://github.com/distributePro/ovsrpro/blob/master/patches/qt5.patch 'patch/diff')|

Qwt

+++ cmake
--- repo
+|[Qwt](http://http://qwt.sourceforge.net/ 'Qwt - Qt Widgets for Technical Applications')|[LGPL](http://qwt.sourceforge.net/qwtlicense.html 'LGPL with exceptions')|The Qwt library contains GUI Components and utility classes which are primarily useful for programs with a technical background.|6.1.2|none|none|
-|[Qwt](http://http://qwt.sourceforge.net/ 'Qwt - Qt Widgets for Technical Applications')|[LGPL](http://qwt.sourceforge.net/qwtlicense.html 'LGPL with exceptions')|The Qwt library contains GUI Components and utility classes which are primarily useful for programs with a technical background.|6.1.2|none|[diff](https://github.com/distributePro/ovsrpro/blob/master/patches/qwtconfig.pri.patch 'patch/diff')|

ZEROMQ

+++ cmake
--- repo
+|[ZEROMQ](https://zeromq.org 'ZEROMQ')|[open](https://github.com/zeromq/libzmq/blob/master/README.md '(See License Section. GNU Lesser General Public LIcense.)')|ZEROMQ is a lightweight messaging kernel is a library that extends standard socket interfaces.|4.2.2|none|none|
-|[ZeroMQ](https://zeromq.org/ 'ZeroMQ - Home")|[LGPL](https://github.com/zeromq/libzmq/blob/master/README.md/ 'LGPL v3')|ZeroMQ is a lightweight messaging kernel that extends standard socket interfaces with more powerful features.|4.2.2|[repo](https://github.com/zeromq/libzmq.git)|none|

Zookeeper

+++ cmake
--- repo
+|[Zookeeper](https://zookeeper.apache.org/ 'Zookeeper - Home')|[open](http://www.apache.org/licenses/ 'Apache V2.0')|Apache ZooKeeper is an effort to develop and maintain an open-source server which enables highly reliable distributed coordination.|3.4.9|[repo](https://github.com/apache/zookeeper 'Zookeeper main repo')|none|
-|[Zookeeper](https://zookeeper.apache.org/ 'Zookeeper - Home')|[open](http://www.apache.org/licenses/ 'Apache V2.0')|Apache ZooKeeper is an effort to develop and maintain an open-source server which enables highly reliable distributed coordination.|3.4.9|[repo](https://github.com/apache/zookeeper.git 'Zookeeper main repo')|[diff](https://github.com/distributePro/ovsrpro/blob/master/patches/zookeeper-windows.patch 'patch/diff (Windows only)')|

This was referenced Jan 27, 2018
@brobeson brobeson added this to the Next Release milestone May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants