upgrade to externpro 18.04.1 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swflb
approved these changes
May 10, 2018
Recall that in #37, @smanders commented that the readme fixes for HDF5, NOVAS, and Qwt required that "ovsrpro uses the not-yet-released-next-release of externpro (newer than 18.01.1)". I assume @smanders made a change to externpro in 18.04.1 which passively resolved #16. That is, the externpro change didn't require us to make a change in ovsrpro. |
|
externpro 18.04.1 includes smanders/externpro#162 which fixes the readme generation for ovsrpro |
|
#approved (post) - been out at a field event... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #43
This also closes #16. When I run CMake to build ovsrpro using externpro 18.04.1, the projects readme file doesn't change.