Fix plugins memory leak

Long story short, when changing NewAgent method to functional params, was done using pointers in the plugins struct. Switching to not use pointers at all allows for the GC to pass.
distribworks · Oct 1, 2019 · e26811a · e26811a
1 parent d0e9943
commit e26811a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/cmd/agent.go b/cmd/agent.go
@@ -55,7 +55,7 @@ func agentRun(args ...string) error {
 	if err := p.DiscoverPlugins(); err != nil {
 		log.Fatal(err)
 	}
-	plugins := &dkron.Plugins{
+	plugins := dkron.Plugins{
 		Processors: p.Processors,
 		Executors:  p.Executors,
 	}

diff --git a/dkron/options.go b/dkron/options.go
@@ -5,12 +5,10 @@ import (
 )
 
 // WithPlugins option to set plugins to the agent
-func WithPlugins(plugins *Plugins) AgentOption {
+func WithPlugins(plugins Plugins) AgentOption {
 	return func(agent *Agent) {
-		if plugins != nil {
-			agent.ProcessorPlugins = plugins.Processors
-			agent.ExecutorPlugins = plugins.Executors
-		}
+		agent.ProcessorPlugins = plugins.Processors
+		agent.ExecutorPlugins = plugins.Executors
 	}
 }