Return zero next schedule when no schedule

This fixes test
distribworks · Mar 13, 2019 · e35560d · e35560d
1 parent f6a5536
commit e35560d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/dkron/job.go b/dkron/job.go
@@ -266,11 +266,15 @@ func (j *Job) Unlock() error {
 
 // GetNext returns the job's next schedule
 func (j *Job) GetNext() (time.Time, error) {
-	s, err := cron.Parse(j.Schedule)
-	if err != nil {
-		return time.Time{}, err
+	if j.Schedule != "" {
+		s, err := cron.Parse(j.Schedule)
+		if err != nil {
+			return time.Time{}, err
+		}
+		return s.Next(time.Now()), nil
 	}
-	return s.Next(time.Now()), nil
+
+	return time.Time{}, nil
 }
 
 func (j *Job) isRunnable() bool {

diff --git a/dkron/job_test.go b/dkron/job_test.go
@@ -48,7 +48,7 @@ func TestJobGetParent(t *testing.T) {
 
 	ptj, err := dependentTestJob.GetParent()
 	assert.NoError(t, err)
-	assert.Equal(t, parentTestJob, ptj)
+	assert.Equal(t, parentTestJob.Name, ptj.Name)
 
 	// Remove the parent job
 	dependentTestJob.ParentJob = ""