Use cobra for commands #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
August 24, 2018 09:24
jjsaunier
reviewed
Aug 25, 2018
dkron/config.go
Outdated
| cmdFlags.String("bind-addr", c.BindAddr, "Address to bind network listeners to.") | ||
| cmdFlags.String("advertise-addr", "", "Address used to advertise to other nodes in the cluster. By default, the bind address is advertised.") | ||
| cmdFlags.String("http-addr", c.HTTPAddr, "Address to bind the UI web server to. Only used when server.") | ||
| cmdFlags.String("discover", c.Discover, "A cluster name used to discovery peers. On networks that support multicast, this can be used to have peers join each other without an explicit join.") |
There was a problem hiding this comment.
I think you can remove or comment it as the feature is no developed, it's missleading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor command line code to use cobra and pflag, also viper to unmarshal config more cleanly. This brings a breaking change in how flags are parsed, they now need double dash
--. Changes in config style also apply, added some code to support old style config.Also remove some deprecated command line params.
Use go modules in Go 1.11 working well so far.