Note in performance section that OT 2.4 requires Java 8 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelovirt
requested changes
Oct 4, 2017
| @@ -35,7 +35,8 @@ | |||
| </section> | |||
| <section> | |||
| <title>Use the latest Java version</title> | |||
| <p>DITA-OT 2.0 requires Java 7, but using the latest version Java 8 will further reduce processing time.</p> | |||
| <p>DITA-OT 2.0 to 2.3 require Java Runtime Environment (JRE) 7, but using JRE 8 with these versions can | |||
There was a problem hiding this comment.
Java 8 is not the latest Java-SE release anymore. Thus this should still say "latest version".
|
@gguillotte Are you able to update this PR per @jelovirt's comments? Otherwise, I'll cherry-pick your changes and revise accordingly. |
[DITA-OT 2.4 and newer require Java 8.](http://www.dita-ot.org/2.4/release-notes/index.html#ID__requirements) Noting that DITA-OT 2.0 requires Java 7 without including this context can lead to confusion if this is the first page of documentation a user encounters. Signed-off-by: Garrett Guillotte <gguillotte@users.noreply.github.com>
infotexture
changed the title
infotexture
approved these changes
Oct 4, 2017
infotexture
added a commit
that referenced
this pull request
Oct 5, 2017
* hotfix/2.5.4: Copyedit Java references Note that Java 8 is required as of 2.4 (#155) Link to docs diff & GitHub changelog Copyedit issue descriptions Sort items by earliest issue ID Use earliest issue as list item ID Enable descriptions for recently resolved issues Draft notes for 2806 Add draft notes for 2805 Update index.dita Clarify system path separator for multiple DITAVALs Draft notes for latest fix in 2.5.4 Draft release notes for existing 2.5.4 issues Prepare 2.5.4 Release Notes stub Bump 'maintenance-version' key to “2.5.4” Use latest DITA-OT version (2.5.3) for CI builds
infotexture
added a commit
that referenced
this pull request
Oct 5, 2017
* hotfix/2.5.4: Copyedit Java references Note that Java 8 is required as of 2.4 (#155) Link to docs diff & GitHub changelog Copyedit issue descriptions Sort items by earliest issue ID Use earliest issue as list item ID Enable descriptions for recently resolved issues Draft notes for 2806 Add draft notes for 2805 Update index.dita Clarify system path separator for multiple DITAVALs Draft notes for latest fix in 2.5.4 Draft release notes for existing 2.5.4 issues Prepare 2.5.4 Release Notes stub Bump 'maintenance-version' key to “2.5.4” Use latest DITA-OT version (2.5.3) for CI builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DITA-OT 2.4 and newer require Java 8. Noting that DITA-OT 2.0 requires Java 7 without including this context can lead to confusion if this is the first page of documentation a user encounters.