-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
121 New TOC organization #162
Conversation
👍 At first glance, this looks like a step in the right direction. I'll pull the changes to build & test locally, then push to a staging server for further review. In the meantime, are you able to update the feature branch and amend your commit with a signoff line per http://www.dita-ot.org/DCO ? It's OK to force-push to your fork in this case: |
Signed-off-by: Shane Taylor <shane@taylortext.com>
@infotexture Signed off. Thanks for reviewing & testing. |
@shaneataylor 🙇 Thanks, this looks like a much better overall structure that should help users to find what they're looking for more quickly. There are still a few rough edges, but I think this will serve as a solid basis for further refinements. Detailed comments to follow… |
Several duplicate topics erroneously appear as children of the landing page. Not sure if that's intentional. |
IMHO 👎 for the Release Notes archive, we have the Documentation versions menu for that. Would also fill the PDF with extra pages and noise. I've long considered removing the old Release Notes topics from the repo entirely, as they can be accessed via Git tags if they're ever needed. — but I realize I may hold a minority position on this topic, so open for other opinions. |
|
"Next topic" links still reflect old hierarchy, but many such things may be coming from reltables and submaps that have not yet been updated, so this is to be expected. |
Installing plug-ins seems to need the context of the old parent Extending the DITA Open Toolkit, though this may be better combined per @xephon2's comments above. |
Building output has too many children. Parameters is better nested under Reference, and the output formats under DITA-OT transformations (though they appear there when viewing the page directly, so this may just be another map hierarchy glitch). |
I think I agree on not having the old versions, and definitely not having them in PDF. It's easy to find by switching versions on the landing page. I'm inclined to keep them in the repo because it means we still have them in the distribution, so people can find them -- I've used that before to more easily figure out when something shipped. Not sure if others have had that need, but I think it's fair to say a large number of DITA-OT users would not know to go look for Git tags if they wanted that info. |
Under Customizing HTML output:
|
@robander, I'd suggest to keep the old PDF notes in a static place and simply add them with <topicref href="DITA-OT-1.8.5-ReleaseNotes.pdf" format="html" scope="external">
<navtitle>1.8.x</navtitle>
<shortdesc>DITA-OT 1.8.x Release Notes</shortdesc>
</topicref> So the user can access all notes the same way and does not have to care for their format. |
I did really like having Parameters at top level of TOC when it moved up back in 2.1 -- for me, it's the thing I look for more than anything in the docs, so having it move to the top level seemed like "Whoa, why didn't we do this ages ago". Yes, I realize I'm an outlier, but looking at current TOC I'm not sure I'd know where to find it, given that history. |
Under Customizing PDF output:
|
👍 for promoting Customizing generated text. |
I recall similar feedback from @jelovirt, so this may be worth considering. I think the focus for the reorganization has been on the needs of first-time users and making things more approachable, but we shouldn't lose sight of veterans' needs entirely. |
Other customizations needs a bit more grouping, but the old Creating plug-ins topic was also a bit … diverse, so this is no surprise. The old plugin overview topics are un-nested, & Customizing generated text was promoted, so shouldn't be here. |
Not sure about Verifying output as a top-level section w/ just one "Log files" child, but if there's more to come it may make sense. I'd be fine leaving the "Log files" topic in Troubleshooting for now, and promote it later as suitable siblings emerge. |
So, that concludes my initial brain dump of feedback. Hoping others will chime in too. For quick straw polls, adding 👍 / 👎 reactions to existing comments makes it easy to tally consensus. |
See #166 for additional thoughts on the re-organization of plugin-related content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this to the feature/new-toc
branch for further adjustments.
* Move spec support & license info to reference * Toolkit needs to be installed before first build Per #162 (comment) Signed-off-by: Roger Sheen <roger@infotexture.net>
Older versions can be accessed via the Documentation versions menu. Per #162 (comment) Signed-off-by: Roger Sheen <roger@infotexture.net>
Per #162 (comment) Signed-off-by: Roger Sheen <roger@infotexture.net>
Per #162 (comment) Signed-off-by: Roger Sheen <roger@infotexture.net>
Per #162 (comment) Signed-off-by: Roger Sheen <roger@infotexture.net>
Per: * #162 (comment) * #162 (comment) * #162 (comment) Fixes #166. Signed-off-by: Roger Sheen <roger@infotexture.net>
Pending additional topics in 'Verifying output' Per #162 (comment) Signed-off-by: Roger Sheen <roger@infotexture.net>
@infotexture Although there's more work to be done generally with the docs, I think this reorganization represents an MVP set of changes that moves us forward.