Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

121 New TOC organization #162

Merged
merged 1 commit into from
Oct 25, 2017
Merged

Conversation

shaneataylor
Copy link
Contributor

@infotexture Although there's more work to be done generally with the docs, I think this reorganization represents an MVP set of changes that moves us forward.

@infotexture infotexture added the enhancement Changes to an existing topic or feature label Oct 16, 2017
@infotexture infotexture added this to the 3.0 milestone Oct 16, 2017
@infotexture
Copy link
Member

👍 At first glance, this looks like a step in the right direction.

I'll pull the changes to build & test locally, then push to a staging server for further review.

In the meantime, are you able to update the feature branch and amend your commit with a signoff line per http://www.dita-ot.org/DCO ?

It's OK to force-push to your fork in this case: git push --force-with-lease yourfork.

@infotexture infotexture added the refactoring Changes to organization of docs source label Oct 16, 2017
Signed-off-by: Shane Taylor <shane@taylortext.com>
@shaneataylor
Copy link
Contributor Author

@infotexture Signed off. Thanks for reviewing & testing.

@infotexture
Copy link
Member

@shaneataylor 🙇 Thanks, this looks like a much better overall structure that should help users to find what they're looking for more quickly.

There are still a few rough edges, but I think this will serve as a solid basis for further refinements. Detailed comments to follow…

@infotexture
Copy link
Member

Several duplicate topics erroneously appear as children of the landing page.

Not sure if that's intentional.

@infotexture
Copy link
Member

IMHO 👎 for the Release Notes archive, we have the Documentation versions menu for that.

Would also fill the PDF with extra pages and noise.

I've long considered removing the old Release Notes topics from the repo entirely, as they can be accessed via Git tags if they're ever needed.

— but I realize I may hold a minority position on this topic, so open for other opinions.

@stefan-jung
Copy link
Contributor

stefan-jung commented Oct 18, 2017

  • I'd suggest to merge Prerequisite software with Installing the DITA Open Toolkit. Currently it's a child, that does not make sense.
  • I'd suggest to rename Extending the DITA Open Toolkit to Plugins, make it a top-level topic, explain there what a plugin is and then make the following topics child nodes of it:
    • Installing plug-ins
    • Removing plug-ins
    • Benefits of plug-ins
    • Plug-in descriptor file
    • Plug-in dependencies
    • Overview of plug-ins
    • Example plugin.xml file
  • Customizing generated text should not be a top-level topic, but should be a child of Globalizing DITA content
  • I'm not happy with the Reference section. This chapter contains the hot stuff, the content should be more popular. Arguments and options for the dita command and DITA-OT parameters should be top-level topics!

@infotexture
Copy link
Member

"Next topic" links still reflect old hierarchy, but many such things may be coming from reltables and submaps that have not yet been updated, so this is to be expected.

@infotexture
Copy link
Member

infotexture commented Oct 18, 2017

Installing plug-ins seems to need the context of the old parent Extending the DITA Open Toolkit, though this may be better combined per @xephon2's comments above.

@infotexture
Copy link
Member

Building output has too many children. Parameters is better nested under Reference, and the output formats under DITA-OT transformations (though they appear there when viewing the page directly, so this may just be another map hierarchy glitch).

@robander
Copy link
Member

robander commented Oct 18, 2017

IMHO 👎 for the Release Notes archive, we have the Documentation versions menu for that.
Would also fill the PDF with extra pages and noise.
I've long considered removing the old Release Notes topics from the repo entirely, as they can be accessed via Git tags if they're ever needed.
— but I realize I may hold a minority position on this topic, so open for other opinions.

I think I agree on not having the old versions, and definitely not having them in PDF. It's easy to find by switching versions on the landing page. I'm inclined to keep them in the repo because it means we still have them in the distribution, so people can find them -- I've used that before to more easily figure out when something shipped. Not sure if others have had that need, but I think it's fair to say a large number of DITA-OT users would not know to go look for Git tags if they wanted that info.

@infotexture
Copy link
Member

Under Customizing HTML output:

@stefan-jung
Copy link
Contributor

@robander, I'd suggest to keep the old PDF notes in a static place and simply add them with

<topicref href="DITA-OT-1.8.5-ReleaseNotes.pdf" format="html" scope="external">
  <navtitle>1.8.x</navtitle>
  <shortdesc>DITA-OT 1.8.x Release Notes</shortdesc>
</topicref> 

So the user can access all notes the same way and does not have to care for their format.

@robander
Copy link
Member

I did really like having Parameters at top level of TOC when it moved up back in 2.1 -- for me, it's the thing I look for more than anything in the docs, so having it move to the top level seemed like "Whoa, why didn't we do this ages ago". Yes, I realize I'm an outlier, but looking at current TOC I'm not sure I'd know where to find it, given that history.

@infotexture
Copy link
Member

Under Customizing PDF output:

@infotexture
Copy link
Member

👍 for promoting Customizing generated text.

For related issues, see #31 & #165.

@infotexture
Copy link
Member

@robander:

I did really like having Parameters at top level of TOC when it moved up back in 2.1

I recall similar feedback from @jelovirt, so this may be worth considering. I think the focus for the reorganization has been on the needs of first-time users and making things more approachable, but we shouldn't lose sight of veterans' needs entirely.

@infotexture
Copy link
Member

Other customizations needs a bit more grouping, but the old Creating plug-ins topic was also a bit … diverse, so this is no surprise.

The old plugin overview topics are un-nested, & Customizing generated text was promoted, so shouldn't be here.

@infotexture
Copy link
Member

Not sure about Verifying output as a top-level section w/ just one "Log files" child, but if there's more to come it may make sense.

I'd be fine leaving the "Log files" topic in Troubleshooting for now, and promote it later as suitable siblings emerge.

@infotexture
Copy link
Member

So, that concludes my initial brain dump of feedback. Hoping others will chime in too.

For quick straw polls, adding 👍 / 👎 reactions to existing comments makes it easy to tally consensus.

@infotexture
Copy link
Member

See #166 for additional thoughts on the re-organization of plugin-related content.

@infotexture infotexture changed the base branch from develop to feature/new-toc October 25, 2017 13:38
Copy link
Member

@infotexture infotexture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this to the feature/new-toc branch for further adjustments.

@infotexture infotexture merged commit 3b87f8a into dita-ot:feature/new-toc Oct 25, 2017
infotexture added a commit that referenced this pull request Oct 26, 2017
* Move spec support & license info to reference
* Toolkit needs to be installed before first build

Per #162 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
infotexture added a commit that referenced this pull request Oct 26, 2017
Older versions can be accessed via the Documentation versions menu.
Per #162 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
infotexture added a commit that referenced this pull request Oct 26, 2017
Per #162 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
infotexture added a commit that referenced this pull request Oct 26, 2017
Per #162 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
infotexture added a commit that referenced this pull request Oct 26, 2017
Per #162 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
infotexture added a commit that referenced this pull request Oct 26, 2017
Per:
* #162 (comment)
* #162 (comment)
* #162 (comment)

Fixes #166.

Signed-off-by: Roger Sheen <roger@infotexture.net>
infotexture added a commit that referenced this pull request Oct 26, 2017
Pending additional topics in 'Verifying output'

Per #162 (comment)

Signed-off-by: Roger Sheen <roger@infotexture.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes to an existing topic or feature refactoring Changes to organization of docs source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants