Info for the dita command, properties files, migrating ant builds #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds. Ignore template.properties and logs/ path.
…pt topic to point to sample.
shaneataylor
force-pushed
the
using_properties_files
branch
from
454303b to
bbf1a7c
Compare
|
The While the example titles do provide the context, the lowercase paths look a bit lost by themselves. |
|
Apart from the comments above, I think this looks like a big improvement. I'll be happy to merge once you review the comments and push an extra commit to address them. |
|
Thanks, @infotexture for the thorough review. I pushed all the suggested changes. 😄 |
infotexture
added a commit
that referenced
this pull request
Feb 8, 2016
Info for the dita command, properties files, migrating ant builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.