updating example and adding method #366

rodydavis · 2020-05-18T22:56:08Z

Adding pickMedia()
Updated Example
Fixing some typos

/// Returns a [PickedFile] with the image that was picked.
  ///
  /// The `source` argument controls where the image comes from. This can
  /// be either [ImageSource.camera] or [ImageSource.gallery].
  /// 
  /// The `type` argument controls what the content return type. This can
  /// be either [RetrieveType.image] or [RetrieveType.video].
  ///
  /// If specified, the image will be at most `imageMaxWidth` wide and
  /// `imageMaxHeight` tall. Otherwise the image will be returned at it's
  /// original width and height.
  ///
  /// The `imageQuality` argument modifies the quality of the image, ranging from 0-100
  /// where 100 is the original/max quality. If `imageQuality` is null, the image with
  /// the original quality will be returned. Compression is only supported for certain
  /// image types such as JPEG. If compression is not supported for the image that is picked,
  /// an warning message will be logged.
  /// 
  /// The [videoMaxDuration] argument specifies the maximum duration of the captured video. If no [videoMaxDuration] is specified,
  /// the maximum duration will be infinite.
  ///
  /// Use `preferredCameraDevice` to specify the camera to use when the `source` is [ImageSource.camera].
  /// The `preferredCameraDevice` is ignored when `source` is [ImageSource.gallery]. It is also ignored if the chosen camera is not supported on the device.
  /// Defaults to [CameraDevice.rear].
  ///
  /// In Android, the MainActivity can be destroyed for various reasons. If that happens, the result will be lost
  /// in this call. You can then call [retrieveLostData] when your app relaunches to retrieve the lost data.
  Future<PickedFile> pickMedia({
    @required ImageSource source,
    @required RetrieveType type,
    double imageMaxWidth,
    double imageMaxHeight,
    int imageQuality,
    Duration videoMaxDuration,
    CameraDevice preferredCameraDevice = CameraDevice.rear,
  }) {
    throw UnimplementedError('pickMedia() has not been implemented.');
  }

Borrowed from Rody Davis' file_access package. Co-authored-by: Rody Davis <rody.davis.jr@gmail.com>

…Update example.

…ings

- Adding pickMedia() - Updated Example - Fixing some typos

ditman

Rody, this looks to me like a new feature for the release after enabling web with the "new" API. Are you in the future already? :P :P Can we release this after the current big PR goes through?

If you have specific changes about the current PR, I'd be glad to merge them, but in this case, the new pickMedia API looks a bit premature, doesn't it?

ditman · 2020-05-19T18:21:43Z

packages/image_picker/image_picker/example/lib/main.dart

@@ -40,7 +40,7 @@ class MyHomePage extends StatefulWidget {
 class _MyHomePageState extends State<MyHomePage> {
  PickedFile _imageFile;
  dynamic _pickImageError;
-  bool isVideo = false;
+  RetrieveType mediaSource = RetrieveType.video;


I'd call this mediaType to not confuse it with the current source (gallery vs camera)

ditman · 2020-05-19T18:30:52Z

packages/image_picker/image_picker/example/lib/main.dart

-          });
-        }
-      });
+    switch (mediaSource) {


I am not a fan of this global controlling the behavior of this method.

Do you think it'd be possible to split _onImageButtonPressed in two methods: _onImageButtonPressed and _onVideoButtonPressed? (Also I've seen other parts of the code using this global-but-not-quite-part-of-the-state variable)

(Anyway, that might be a refactor for another time)

ditman · 2020-05-19T18:38:57Z

...picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart

+    @required ImageSource source,
+    @required RetrieveType type,
+    double imageMaxWidth,
+    double imageMaxHeight,
+    int imageQuality,
+    Duration videoMaxDuration,
+    CameraDevice preferredCameraDevice = CameraDevice.rear,


I like this change, but I'd prefer to add this after the web version is in, to not add a new platform + new functionality. Can we do this in a follow up to the current change?

About the functionality itself, this seems to be a big fusion of all the pick* methods that are currently implemented. If "pickAudio" or "pickFile" get added, this method will grow in complexity (it'll probably need more parameters).

Maybe the best way to go is to have a completely agnostic "pickFile" method that lets you select anything from the disk.

That API can have the RetrieveType parameter if we want to limit to some types, but it wouldn't concern itself with "imageQuality" or "videoDuration".

That would be a much simpler API, if you needed to pick from multiple types IMO!

ditman · 2020-05-19T18:42:51Z

...cker/image_picker_platform_interface/lib/src/method_channel/method_channel_image_picker.dart

+    Duration videoMaxDuration,
+    CameraDevice preferredCameraDevice = CameraDevice.rear,
+  }) {
+    switch (type) {


We should avoid these switches on Enum IMO, because when you add a new value to the Enum, you break whoever was switching on it, if they don't have a default case.

There should always be a default case (or possibly better, not switch on Enums :P)

rodydavis · 2020-05-19T21:18:37Z

Oh for sure! Yeah I was just making it to show you what I was thinking. PR is fine as it is 👍🏼

ditman · 2020-05-19T23:28:40Z

@rodydavis let's revisit this, after the web version gets merged. What do you think about having a less specific pickFile instead of an "union" method to Rule Them All?

I'm sure this was inspired by your own use cases of the picker in the past, I'm very curious! (We can discuss via email if you prefer)

rodydavis · 2020-05-19T23:33:01Z

Yeah I like the idea of it being less specific for sure. For many apps though I need to rebuild the logic for picking a photo, image or file and they all usually are under a onpressed event and return a file. Having a pickFile would be great to add. And then if it is filtered to just photos or videos it would choose appropriately.

Side note, are there plans to support saving image, photos and videos too? That’s a bother thing I’m heavily replicating, but could also be another plugin

ditman · 2020-05-19T23:43:42Z

I think saving needs to be a separate plugin. It's super transparent for the mobile use case, but it's not so clear in the Browser. (I'm concerned with initializing the file in a way that makes sense with the mobile code :/)

ditman and others added 11 commits May 14, 2020 17:16

Introduce the PickedFile class to have a more platform agnostic return.

be5831f

Borrowed from Rody Davis' file_access package. Co-authored-by: Rody Davis <rody.davis.jr@gmail.com>

Modify the platform interface to return PickedFiles.

7b700a8

Add new API to the image_picker, and mark old methods as deprecated. …

ca8119a

…Update example.

Add image_picker_for_web plugin.

b421fe0

Make API Async, so web can use objectUrls internally, instead of bytes.

e1ee13d

Modify core image_picker so it uses the new APIs, and add web example

9e43c73

[image_picker] Ignore deprecated use analyzer warnings

9ca897d

[image_picker_platform_interface] Ignore deprecated use analyzer warn…

ac807f8

…ings

[image_picker_for_web] Remove copypaste from test file.

93ed49c

[image_picker] Bump changelog and version

aae9c08

updating example and adding method

c49f372

- Adding pickMedia() - Updated Example - Fixing some typos

rodydavis mentioned this pull request May 18, 2020

[image_picker] 🚧 Add support for web 🚧 flutter/plugins#2767

Closed

12 tasks

ditman reviewed May 19, 2020

View reviewed changes

ditman force-pushed the image-picker-web branch from 2507d3b to e426c9a Compare May 20, 2020 18:36

rodydavis closed this May 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updating example and adding method #366

updating example and adding method #366

rodydavis commented May 18, 2020

ditman left a comment

ditman May 19, 2020

ditman May 19, 2020

ditman May 19, 2020

ditman May 19, 2020

rodydavis commented May 19, 2020

ditman commented May 19, 2020

rodydavis commented May 19, 2020

ditman commented May 19, 2020

updating example and adding method #366

updating example and adding method #366

Conversation

rodydavis commented May 18, 2020

ditman left a comment

Choose a reason for hiding this comment

ditman May 19, 2020

Choose a reason for hiding this comment

ditman May 19, 2020

Choose a reason for hiding this comment

ditman May 19, 2020

Choose a reason for hiding this comment

ditman May 19, 2020

Choose a reason for hiding this comment

rodydavis commented May 19, 2020

ditman commented May 19, 2020

rodydavis commented May 19, 2020

ditman commented May 19, 2020