Pass through ResolveTypes from Webpack
#93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #88.
|
Thanks! |
jonaskello
added a commit
that referenced
this pull request
Jul 29, 2022
This reverts commit dc3dd37.
jonaskello
added a commit
that referenced
this pull request
Jul 29, 2022
This reverts commit dc3dd37.
|
I think this PR has value but I had to revert it for now because it broke compilation. I did some changes to the CI process for PRs so hopefully non-compiling PRs will be caught now. Please try again with this change if you want. |
|
I'll take a look and see if I can resolve this now, then file a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #88.
Note that I'm unsure why
extensionswas originally defined asReadonlyArray, but I am pretty sure the intent is to accept the exact types coming from Webpack. So there might still be an internal change needed to account for this change in type.