Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass builderArgs to config and extract builds #266

Merged
merged 1 commit into from
May 2, 2021
Merged

pass builderArgs to config and extract builds #266

merged 1 commit into from
May 2, 2021

Conversation

Pacman99
Copy link
Member

@Pacman99 Pacman99 commented Apr 28, 2021 •
edited
Loading

have mkHomeConfiguration create its own custom build within the function
create a externalModule for customBuilds so its easy to add more

closes #170

@Pacman99 Pacman99 changed the title pass builderArgs as specialArgs and extract builds pass builderArgs as specialArg and extract builds Apr 28, 2021
@Pacman99 Pacman99 changed the title pass builderArgs as specialArg and extract builds pass builderArgs to config and extract builds Apr 28, 2021
Pacman99
Pacman99 commented Apr 28, 2021
View reviewed changes
lib/devos/devosSystem.nix Outdated Show resolved Hide resolved
blaggacao
blaggacao reviewed Apr 28, 2021
View reviewed changes
lib/mkFlake/default.nix Outdated Show resolved Hide resolved
blaggacao
blaggacao reviewed Apr 28, 2021
View reviewed changes
modules/customBuilds.nix Outdated Show resolved Hide resolved
blaggacao
blaggacao reviewed Apr 28, 2021
View reviewed changes
lib/devos/default.nix Outdated Show resolved Hide resolved
@Pacman99 Pacman99 force-pushed the extract-builds branch 2 times, most recently from aa17170 to 45073c6 Compare April 28, 2021 19:50
@Pacman99 Pacman99 requested a review from nrdxp April 29, 2021 17:52
@Pacman99 Pacman99 force-pushed the extract-builds branch 7 times, most recently from 120a7aa to de9160d Compare April 30, 2021 17:51
pass builderArgs to config and extract builds
e98e595 
have mkHomeConfiguration create its own custom build within the function
create a externalModule for customBuilds so its easy to add more
@Pacman99
Copy link
Member Author

Pacman99 commented Apr 30, 2021 •
edited
Loading

Updates:

  • Moved mkBuild and hmConfig to be in customBuilds. So theres now a dedicated location for everything "build" related. I don't see a reason to use mkBuild outside of customBuilds.nix and it could even be harmful to do so.
  • set _module.args.devlib in globalDefaults
  • made mkHomeConfigurations more portable, so it can be used for non-devos hosts

@Pacman99 Pacman99 requested a review from blaggacao April 30, 2021 17:54
@blaggacao
Copy link
Contributor

I'll review as soon as I'm getting a hold on a computer again.

But from the entire context I have, I would say, go ahead and merge if you feel it's ready.

@Pacman99 Pacman99 merged commit 378107f into divnix:develop May 2, 2021
@Pacman99 Pacman99 mentioned this pull request May 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrdxp nrdxp Awaiting requested review from nrdxp

@blaggacao blaggacao Awaiting requested review from blaggacao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pacman99 @blaggacao