Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboards crashing #3

Closed
snomos opened this issue Jul 23, 2024 · 5 comments
Closed

Keyboards crashing #3

snomos opened this issue Jul 23, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@snomos
Copy link
Member

snomos commented Jul 23, 2024

At least the following keyboards are crashing when activated:

  • Meänkieli/fit
  • Runic Nynorsk/nn-Runr
  • Livvi/olo
  • South Sámi

iOS version: 17.5.1
Model: XS Max

@zoomix this is high priority.

@snomos snomos added the bug Something isn't working label Jul 23, 2024
@snomos
Copy link
Member Author

snomos commented Jul 24, 2024

Here's a video showing a number of issues including crashes, with oral comments.

SteffenErn added a commit that referenced this issue Aug 6, 2024
@SteffenErn SteffenErn reopened this Aug 6, 2024
@SteffenErn
Copy link
Contributor

WIP:
Livvi/olo cashes on iOS due to an issue with the KeyboardDefinitions.json file
BaseKeyboard/KeyboardViewController.swift:250: Fatal error: Error getting keyboard definitions from json file: keyNotFound(Keys(stringValue: "normal", intValue: nil), Swift.DecodingError.Context(codingPath: [_JSONKey(stringValue: "Index 9", intValue: 9), Keys(stringValue: "ipad-9in", intValue: nil)], debugDescription: "No value associated with key Keys(stringValue: \"normal\", intValue: nil) (\"normal\").", underlyingError: nil))
However during build process this file is correct. Investigating further...

@SteffenErn
Copy link
Contributor

SteffenErn commented Aug 7, 2024

This happens because Livonian does not have keyboard definitions for iPad. Either those definitions get added, the keyboard removed from the app or the app changed so it doesn't crash on missing ipad definitions.
@snomos What should we do?

SteffenErn added a commit to divvun/giellakbd-ios that referenced this issue Aug 8, 2024
@SteffenErn
Copy link
Contributor

This commit fixes the crashing keyboards. New version of the dev app is submitted to app store and should be available soon

@snomos
Copy link
Member Author

snomos commented Aug 8, 2024

Looks almost good:

  • Livonian keyboard is now available and working on iPhone
  • no crashes detected after a short period of testing

There are still non-crashing issues on the iPad, see #4.

@snomos snomos reopened this Aug 8, 2024
@snomos snomos closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants