Display message when keyboard not supported on current device #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanhand
changed the title
|
NOTE: This feature is not complete. Merging now because I was tragically reminded that it's not possible to trigger test builds from branches of this repo with the current CI setup. Therefore this must be merged to push a new build via https://github.com/divvun/divvun-dev-keyboard for testing/feedback. Some things left to do:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for divvun/divvun-dev-keyboard#4
Currently, if a keyboard definition is missing an iPad layout, the keyboard crashes on iPad and goes to the default keyboard.
Since it appears not possible to remove the keyboard from the list of enable-able keyboards under Settings > Keyboard (see issue for more info), the proposed fix is to display a message in the keyboard view on when the keyboard is not available for the current device.