Enhance missing layout message #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't like it
This reverts commit 7e0a7d2.
Still don't love it but it's much fewer code changes and should be safe enough
…esn't support it In order to show the user info about *which* keyboard is not supported, and in the future allow them to request it, we need to know what keyboard we're talking about. Using a failable initializer was safer than this, but kept us from knowing anything about the keyboard definition in question. Will probably refactor to make `layoutForCurrentDevice` an optional property of `KeyboardDefinition` so this is safer and more clear.
We can't have nice things from an App Extension. This workaround lets us open URLs despite not having access to UIApplication.shared.
This reverts commit 8c0bdb5.
Test for empty instead of nil
dylanhand
force-pushed
the
enhance-missing-layout-message
branch
from
d4c187b to
a1abf90
Compare
|
See above for things left to do. Merging now to test with divvun-dev-keyboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further fixes/enhancements for divvun/divvun-dev-keyboard#4
Done:
Todo:
Test that keyboard locales are working correctly -- the keyboard definition used for testing is either wonky or this will need to changeRefactor how we retain info about the current keyboard when it's not supported and didn't load (see detailed commit message for a9361d6)