Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cancelAnimation when calling destroy method #132

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

tomsjer
Copy link

@tomsjer tomsjer commented Oct 12, 2018

Hi, thanks for this tiny plugin.

I've added some logic to clear the loop once the destroy method gets called. Although GC takes care of cleaning things up, IMHO its better to explicitly cancel the request when its not being used.
Specially when developing a SPA.

Cheers.

@moeamaya moeamaya merged commit d56f3e0 into dixonandmoe:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants