Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use poll() instead of select() if available #161

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use poll() instead of select() if available #161

wants to merge 3 commits into from

Conversation

lnqs
Copy link

@lnqs lnqs commented Mar 24, 2016

select() doesn't work with file-descriptiors > FD_SETSIZE, which is 1024
per default.
In long-running processes that use a lot of FDs, this limit can be
reached quickly, causing the calls to select() to fail.

poll() doesn't have this restriction, while it is available on most
systems. Therefore, it is used over select() if possible.
On systems where it isn't available (esp. older versions of windows),
the code falls back to utilize select().

Simon Schönfeld added 3 commits March 23, 2016 14:19
select() doesn't work with file-descriptiors > FD_SETSIZE, which is 1024
per default.
In long-running processes that use a lot of FDs, this limit can be
reached quickly, causing the calls to select() to fail.

poll() doesn't have this restriction, while it is available on most
systems. Therefore, it is used over select() if possible.
On systems where it isn't available (esp. older versions of windows),
the code falls back to utilize select().
sf-jin-ku pushed a commit to sendbird-graveyard/PyAPNs that referenced this pull request Jun 11, 2018
sf-jin-ku pushed a commit to sendbird-graveyard/PyAPNs that referenced this pull request Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant