Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Harvest API Credentials be added after initialisation #2

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Allow Harvest API Credentials be added after initialisation #2

merged 1 commit into from
Oct 31, 2018

Conversation

RandomWeasel
Copy link
Contributor

  • Update Gateway to allow Harvest API Credentials to be set after initialisation:
  • Get credentials from config in __construct method
  • remove exception thrown by $this->hasCredentials in __construct, as they may not be set at this point
  • modify get() method to explicitly set headers with credentials from config

@RandomWeasel
Allow Harvest API Credentials be added later
8f5ba1d 
- Update Gateway to allow Harvest API Credentials to be set after initialisation:
- Get credentials from config in __construct method
- remove exception thrown by $this->hasCredentials in __construct, as they may not be set at this point
- modify get() method to explicitly set headers with credentials from config
@djam90 djam90 merged commit a4216ed into djam90:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djam90 djam90 djam90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RandomWeasel @djam90