Skip to content
This repository has been archived by the owner on Nov 27, 2019. It is now read-only.

Added extra_class to filer_image. #118

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jrutila
Copy link

@jrutila jrutila commented Apr 1, 2014

One can add extra string for the image that will be appended to the class-tag.

This is useful for example if one would need to add like img-responsive class to images when using wrapbootstrap templates.

@stefanfoulis
Copy link
Contributor

Wouldn't you want all images site wide to be responsive (so you'd override the image template and hardcode the change)?

That being said, we introduced a configurable "style" on most plugins, which can be used to render with selectable templates.

@jrutila
Copy link
Author

jrutila commented Jun 5, 2014

I think in some cases it depends on what page and slot the image is in. So maybe it should be also 'certain placeholder in certain template' -wide. So one should be able to override the image template for certain templates placeholder. Would this sound any good? Where can it be configured then?

@stefanfoulis
Copy link
Contributor

For the "certain placeholder" case you could wrap the whole placeholder in a div with a class and use that for styling.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants