Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Define a default_auto_field on the app config #1294

Merged
merged 2 commits into from
Jun 5, 2022

Conversation

marksweb
Copy link
Member

@marksweb marksweb commented Jun 4, 2022

Description

This defines a default_auto_field on the app config so django won't try to create migrations for the app if someone moves their project to big auto field.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #1294 (3f4f706) into master (ee1a72e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1294   +/-   ##
=======================================
  Coverage   72.20%   72.21%           
=======================================
  Files          72       72           
  Lines        3238     3239    +1     
  Branches      563      563           
=======================================
+ Hits         2338     2339    +1     
  Misses        734      734           
  Partials      166      166           
Impacted Files Coverage Δ
filer/apps.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee1a72e...3f4f706. Read the comment docs.

@marksweb marksweb merged commit d56991e into django-cms:master Jun 5, 2022
@marksweb marksweb deleted the fix/1293 branch June 5, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants