-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Fix tests and add pre-commit #1306
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1306 +/- ##
==========================================
+ Coverage 72.18% 72.21% +0.02%
==========================================
Files 72 72
Lines 3236 3239 +3
Branches 559 563 +4
==========================================
+ Hits 2336 2339 +3
Misses 734 734
Partials 166 166
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know about pre-commit
and will apply that to my other projects
@jrief It's a very neat tool for improving a workflow & catching issues before you get to a PR & workflows - especially linters. |
Description
This addresses issues with tests and adds pre-commit config for linting & basic checks to hopefully prevent the linter workflow failing on PRs.
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.