Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix tests and add pre-commit #1306

Merged
merged 8 commits into from
Aug 5, 2022

Conversation

marksweb
Copy link
Member

@marksweb marksweb commented Aug 5, 2022

Description

This addresses issues with tests and adds pre-commit config for linting & basic checks to hopefully prevent the linter workflow failing on PRs.

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@marksweb marksweb requested a review from jrief August 5, 2022 00:01
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #1306 (0c94147) into master (6a4706d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1306      +/-   ##
==========================================
+ Coverage   72.18%   72.21%   +0.02%     
==========================================
  Files          72       72              
  Lines        3236     3239       +3     
  Branches      559      563       +4     
==========================================
+ Hits         2336     2339       +3     
  Misses        734      734              
  Partials      166      166              
Impacted Files Coverage Δ
filer/urls.py 100.00% <ø> (ø)
filer/admin/folderadmin.py 71.82% <100.00%> (ø)
filer/thumbnail_processors.py 38.46% <100.00%> (ø)
filer/utils/compatibility.py 59.09% <100.00%> (ø)
filer/utils/files.py 69.87% <100.00%> (ø)
filer/admin/views.py 65.71% <0.00%> (+1.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

setup.cfg Show resolved Hide resolved
Copy link
Collaborator

@jrief jrief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know about pre-commit and will apply that to my other projects

@jrief jrief merged commit fd60809 into django-cms:master Aug 5, 2022
@marksweb marksweb deleted the fix/test-apps/auto-field branch August 5, 2022 12:28
@marksweb
Copy link
Member Author

marksweb commented Aug 5, 2022

I didn't know about pre-commit and will apply that to my other projects

@jrief It's a very neat tool for improving a workflow & catching issues before you get to a PR & workflows - especially linters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants