fix: Allow Image.MAX_IMAGE_PIXELS
to be None
#1475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related resources
We discourage to do this, but
PIL.Image.MAX_IMAGE_PIXELS
can beNone
. If so, please specifyFILE_MAX_IMAGE_SIZE
in yoursettings.py
. If both are not set, any admin user can upload images as big as they wish opening up any project to memory bombs.This PR allows
PIL.Image.MAX_IMAGE_PIXELS
to beNone
. If bothPIL.Image.MAX_IMAGE_PIXELS
andsettings.FILER_MAX_IMAGE_PIXELS
are not set, the checks framework will raise a warning.Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.