Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.0.0 #172

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Release 5.0.0 #172

merged 3 commits into from
Jan 7, 2025

Conversation

joshyu
Copy link
Contributor

@joshyu joshyu commented Nov 7, 2024

Description

  • feat: Universal support for django CMS 3.11 and 4.x

Checklist

  • [x ] I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #pr-review on
    Discord to find a “pr review buddy” who is
    going to review my pull request.

Summary by Sourcery

Release version 5.0.0.

New Features:

  • Universal support for django CMS 3.11 and 4.x.

Tests:

  • Updated test settings.

@fsbraun
Copy link
Member

fsbraun commented Nov 7, 2024

@joshyu To get the tests running, try replacing coverage run setup.py test by coverage run tests/settings.py

@fsbraun fsbraun marked this pull request as ready for review January 7, 2025 06:53
@fsbraun fsbraun merged commit 705e10d into django-cms:master Jan 7, 2025
5 of 6 checks passed
Copy link

sourcery-ai bot commented Jan 7, 2025

Reviewer's Guide by Sourcery

This pull request prepares django CMS Snippet for release 5.0.0 by finalizing the version number and updating test settings.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update version number to 5.0.0
  • Changed version number from 5.0.0a1 to 5.0.0
  • Added dynamic versioning configuration to pyproject.toml
src/djangocms_snippet/__init__.py
pyproject.toml
Update test settings
  • Modified the test command to use a custom settings file (tests/settings.py) instead of the default setup.py test command
tox.ini

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @joshyu - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The change in test execution from setup.py test to tests/settings.py in tox.ini is significant and needs explanation. Please provide context for this change.
  • The PR description mentions universal support for django CMS 3.11 and 4.x, but there are no visible changes in the codebase supporting this claim. Please clarify how this compatibility is achieved.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants