-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.0.0 #172
Release 5.0.0 #172
Conversation
@joshyu To get the tests running, try replacing |
Reviewer's Guide by SourceryThis pull request prepares django CMS Snippet for release 5.0.0 by finalizing the version number and updating test settings. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @joshyu - I've reviewed your changes - here's some feedback:
Overall Comments:
- The change in test execution from
setup.py test
totests/settings.py
in tox.ini is significant and needs explanation. Please provide context for this change. - The PR description mentions universal support for django CMS 3.11 and 4.x, but there are no visible changes in the codebase supporting this claim. Please clarify how this compatibility is achieved.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Description
Checklist
master
Discord to find a “pr review buddy” who is
going to review my pull request.
Summary by Sourcery
Release version 5.0.0.
New Features:
Tests: