Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removing slug field from list display when versioning is enabled #98

Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Changelog
Unreleased
==========

* fix: Slug field on list display for admin should only be displayed when versioning is not available

4.0.0.dev2 (2021-12-22)
=======================
Expand Down
26 changes: 23 additions & 3 deletions djangocms_snippet/admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,8 @@


class SnippetAdmin(*snippet_admin_classes):
list_display = ('slug', 'name')
search_fields = ['slug', 'name']
prepopulated_fields = {'slug': ('name',)}
list_display = ('name',)
search_fields = ['name']
change_form_template = 'djangocms_snippet/admin/change_form.html'
text_area_attrs = {
'rows': 20,
Expand All @@ -46,6 +45,27 @@ class SnippetAdmin(*snippet_admin_classes):
class Meta:
model = Snippet

def get_list_display(self, request):
list_display = super().get_list_display(request)
list_display = list(list_display)

if not djangocms_versioning_enabled:
Bernardvdv marked this conversation as resolved.
Show resolved Hide resolved
list_display.insert(0, 'slug')
list_display = tuple(list_display)
return list_display

def get_search_fields(self, request):
search_fields = super().get_search_fields(request)
if not djangocms_versioning_enabled:
Bernardvdv marked this conversation as resolved.
Show resolved Hide resolved
search_fields.append('slug')
return search_fields

def get_prepopulated_fields(self, obj, request):
prepopulated_fields = super().get_prepopulated_fields(request)
if not djangocms_versioning_enabled:
prepopulated_fields = {'slug': ('name',)}
Bernardvdv marked this conversation as resolved.
Show resolved Hide resolved
return prepopulated_fields

def get_urls(self):
info = self.model._meta.app_label, self.model._meta.model_name
return [
Expand Down