-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release 0.2.6 #12
Conversation
14b4b56
to
3a9b5f2
Compare
I reformatted the `settings` section, to display vars as a table. I also put `code-block` directives for snippets.
The key `merchantSig` has been updated accordingly.
e055cd0
to
a80ddac
Compare
LGTM. |
a80ddac
to
1a6888f
Compare
# manually add the pip cache directory to the build cache. | ||
# (from django-oscar/.travis.yml) | ||
directories: | ||
- ~/.cache/pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fancy! But I'm not sure if it works without the new container based infrastructure: https://github.com/django-oscar/django-oscar/blob/master/.travis.yml#L1
Frankly, this is such a simple project, I wouldn't bother with either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frankly, this is such a simple project, I wouldn't bother with either.
Agreed. I might just remove it, it's not that necessary on a small project. I prefer to keep things simple.
I also moved adyen/tests.py to tests/test_adyen.py.
1a6888f
to
4e25149
Compare
I just:
settings
section, to display vars as a table.code-block
directives for snippets.example.com
for URLs and emails • Add country codeFinally, I bumped version 0.2.6 that will be uploaded on PyPI.