-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify raw_path
Definition for WebSockets Protocol in the Specification
#468
Comments
Yeah, having this difference looks a bit weird. Do you remember if it was intentional? @andrewgodwin |
I do not believe that was intentional - my guess is that we specifically clarified it for standard HTTP but not for WebSocket. I would say we should update the WebSocket side to say that it also excludes the query string. |
@raptium Would you like to send a PR here? |
andrewgodwin
pushed a commit
that referenced
this issue
Oct 18, 2024
We can close this @andrewgodwin 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The definition of
raw_path
in the ASGI specification differs slightly between HTTP and WebSockets protocols.raw_path
.asgiref/specs/www.rst
Lines 107 to 110 in b7aaa79
raw_path
.asgiref/specs/www.rst
Lines 318 to 321 in b7aaa79
To ensure clarity and consistency, it would be beneficial to explicitly define the behavior of
raw_path
for WebSockets:Given the potential for confusion, it would be helpful to clarify this in the specification.
The text was updated successfully, but these errors were encountered: