Edits

CHANGELOG.txt

@@ -1,6 +1,13 @@
 Full release notes, with more details and upgrade information, are available at:
 https://channels.readthedocs.io/en/latest/releases
 
+UNRELEASED
+----------
+
+* Adjusted HTTP body handling to use a spooled file, rather than reading
+  request body into memory. ``AsgiRequest.__init__()`` is adjusted to expected
+  an IO stream, rather than bytes.
+
 2.2.0 (2019-04-14)
 ------------------
 

channels/http.py

@@ -131,7 +131,6 @@ def _get_scheme(self):
 
     def _get_post(self):
         if not hasattr(self, "_post"):
-            self._read_started = False
             self._load_post_and_files()
         return self._post
 
@@ -140,7 +139,6 @@ def _set_post(self, post):
 
     def _get_files(self):
         if not hasattr(self, "_files"):
-            self._read_started = False
             self._load_post_and_files()
         return self._files
 

tests/test_http.py

@@ -5,7 +5,7 @@
 
 import pytest
 from django.core.exceptions import RequestDataTooBig
-from django.http import HttpResponse
+from django.http import HttpResponse, RawPostDataException
 from django.test import override_settings
 
 from asgiref.testing import ApplicationCommunicator
@@ -170,6 +170,25 @@ def test_script_name(self):
 
         self.assertEqual(request.path, "/path/to/test/")
 
+    def test_reading_body_after_stream_raises(self):
+        request = AsgiRequest(
+            {
+                "http_version": "1.1",
+                "method": "POST",
+                "path": "/test2/",
+                "query_string": "django=great",
+                "headers": {
+                    "host": b"example.com",
+                    "content-type": b"application/x-www-form-urlencoded",
+                    "content-length": b"18",
+                },
+            },
+            BytesIO(b"djangoponies=are+awesome"),
+        )
+        self.assertEqual(request.read(3), b"dja")
+        with pytest.raises(RawPostDataException):
+            request.body
+
     def test_size_exceeded(self):
         with override_settings(DATA_UPLOAD_MAX_MEMORY_SIZE=1):
             with pytest.raises(RequestDataTooBig):