Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #1245: Header keys and values must be bytestrings according to the spec #1246

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Fixed #1245: Header keys and values must be bytestrings according to the spec #1246

merged 1 commit into from
Feb 12, 2019

Conversation

matthiask
Copy link
Contributor

@matthiask matthiask commented Feb 10, 2019 •
edited by carltongibson
Loading

Closes #1245.

@matthiask
Copy link
Contributor Author

By the way, it would of course be possible to add some code to channels itself checking the type of the header keys and values. I'm not convinced it's worth it because Daphne's error message is quite clear.

Also, I'm just fixing my own oversight here. (5189b12)

carltongibson
carltongibson approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. This is good, thanks @matthiask.

...it would of course be possible to add some code to channels itself checking the type of the header keys and values...

Yeah, hmm. I think probably Out of Scope at the moment. I'd rather keep things functional and vanilla right now.

@matthiask
Copy link
Contributor Author

...it would of course be possible to add some code to channels itself checking the type of the header keys and values...

Yeah, hmm. I think probably Out of Scope at the moment. I'd rather keep things functional and vanilla right now.

I agree completely.

@carltongibson carltongibson merged commit a660d81 into django:master Feb 12, 2019
shjohnson-pi pushed a commit to shjohnson-pi/channels that referenced this pull request May 28, 2019
@matthiask @shjohnson-pi
Corrected docs & tests re that headers must use bytestrings. (django#…
72178ae 
…1246)
@carltongibson carltongibson mentioned this pull request Aug 7, 2019
Closed
@matthiask matthiask deleted the mk/1245 branch August 11, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

@carltongibson carltongibson carltongibson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthiask @carltongibson @auvipy