add new entities for SEC module using the right columns from dataCountlist #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santiagozky
force-pushed
the
new-entities-for-sec-module
branch
from
f5ffcdb
to
c308b5d
Compare
|
updated the branch since I had made my original commit using my work email 🤦🏼 |
djansen1987
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the other PR, I kept the behaviour of the current SEC entities as they are and added a couple of new entities that match the data they provide.
I added deprecation notice to them to signal new users the new ones are the ones to choose from, but we dont need to remove the existing ones.
I was thinking if we should add an info or warn logging if users use the existing ones, I can add them if needed.
Here are some screenshots comparing the old and new entities vs a screenshot of my SAJ account. (nowPower has never come from that particular json even thought could also be obtained there)