Moved no-receiver size_hint method to a separate trait #270
Conversation
|
In this one, why isn't |
|
Yes. I could move that into the other trait too (and rename the new trait) if desired. |
|
(and in that case the Sized bound would no longer be needed) |
|
So as an alternative, could we add a |
|
It works, but you have to also add a |
askama/src/lib.rs
Outdated
| fn dyn_size_hint(&self) -> usize; | ||
| } | ||
|
|
||
| pub trait TemplateSizeHint { |
There was a problem hiding this comment.
Let's rename this to SizedTemplate and move both extension() and size_hint() into it?
askama/src/lib.rs
Outdated
| @@ -502,6 +502,10 @@ pub trait Template { | |||
| fn extension() -> Option<&'static str> | |||
| where | |||
| Self: Sized; | |||
| fn dyn_size_hint(&self) -> usize; | |||
There was a problem hiding this comment.
I would say maybe we can just name this size_hint() for now? Not sure if the conflict causes issues in the common case.
There was a problem hiding this comment.
If they have the same name then importing SizedTemplate and trying to use the receiverless size_hint() will give a "multiple applicable items in scope" compile error if Template is also imported.
There was a problem hiding this comment.
Doesn't it basically make the receiverless size_hint() unusable? Or is there a way to disambiguate?
(Giving extension() the same treatment causes the same compile error in testing/tests/simple.rs.)
There was a problem hiding this comment.
I think you can do something like SizedTemplate::extension(&t) or <t as SizedTemplate>::extension().
There was a problem hiding this comment.
ah yes, it works. I've updated the PR.
|
Thanks for sticking with it and working through this with me! |
|
(Also, I'd be curious to hear a little bit more about what you're using Askama for.) |
No description provided.