derive: Shrink dependency list #771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need the more advanced features that `quote` and `syn` offer. This PR opts out of using them. Until <rust-lang/rust#92565> is resolved, we cannot give a better error location than `#[derive(Template)]` itself. So we don't need to keep track of the span in our `struct CompileError`, and we can remove the dependency of `proc_macro2`.
|
I didn't notice that the extra features were pulled in by some other dependency and they were, if fact, needed. :D The direct dependency to |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need the more advanced features that
quoteandsynoffer. This PR opts out of using them.Until rust-lang/rust#92565 is resolved, we cannot give a better error location than
#[derive(Template)]itself. So we don't need to keep track of the span in ourstruct CompileError, and we can remove the dependency ofproc_macro2.