Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use gcloud for getting user auth #31

Merged
merged 12 commits into from
Aug 4, 2021

Conversation

thrykol
Copy link
Contributor

@thrykol thrykol commented Aug 3, 2021

No description provided.

@hrvolapeter hrvolapeter requested review from djc and hrvolapeter August 4, 2021 09:04
Copy link
Collaborator

@hrvolapeter hrvolapeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I would maybe wait for #30 to be merged which contains some checks through githubactions

closes #27

@hrvolapeter
Copy link
Collaborator

@thrykol could you fix the conflict with master? I would do it but the changes are in your fork.

@djc
Copy link
Owner

djc commented Aug 4, 2021

Would be nice to rebase this rather than merge it. Hopefully it's not too much of a pain!

@thrykol
Copy link
Contributor Author

thrykol commented Aug 4, 2021

@hrvolapeter conflicts have been resolved in the fork. Once this gets merged, what's the process for rolling a new release?

@hrvolapeter hrvolapeter merged commit 3007b55 into djc:master Aug 4, 2021
@hrvolapeter
Copy link
Collaborator

Hi @thrykol, thanks for the conflicts, I'll first do some checks on the current master and I'll push new version to cargo hopefully today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants