Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix exposing secrets in logs with custom sa #58

Merged
merged 2 commits into from
Dec 21, 2022
Merged

fix exposing secrets in logs with custom sa #58

merged 2 commits into from
Dec 21, 2022

Conversation

hrvolapeter
Copy link
Collaborator

Fixes #55

@hrvolapeter hrvolapeter requested a review from djc October 10, 2022 19:58
@djc
Copy link
Owner

djc commented Oct 12, 2022

(This is failing CI -- not entirely sure why.)

@hrvolapeter hrvolapeter merged commit c6eedc1 into master Dec 21, 2022
@hrvolapeter hrvolapeter deleted the tracing-secret branch December 21, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using #[tracing::instrument] on refresh_token() leaks sensitive information to logs
2 participants
@hrvolapeter @djc