Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrated from cra to vite #513

Merged
merged 17 commits into from
Jan 28, 2025
Merged

Conversation

isazaharadeen
Copy link
Contributor

@isazaharadeen isazaharadeen commented Jan 26, 2025

closes #501

  • Install & Configure Vite

  • Remove all CRA dependencies (e.g., react-scripts) and add Vite as a dev dependency.

  • Create the necessary config files (e.g., vite.config.js) to match the current setup from CRA.

  • Update scripts in package.json for development and production builds using Vite.

  • Update Project Structure

  • Update environment variable usage

  • Ensure that any custom ESLint configurations remain valid or are properly migrated into the new setup.

  • Ensure that all Babel-related configuration is removed and project still works as before

  • Docker Integration

  • Update the Dockerfile to build the app with Vite instead of CRA.

  • Make sure docker-compose setup still function correctly.

  • Verify that both local and Docker builds are successful and the app runs without issues.

  • Testing

  • Run the test suite to ensure there are no regressions.

  • Make sure that any test commands Jest are updated for the new environment.

  • Update README.md to reflect the new setup (i.e., how to run locally, how to build).

@isazaharadeen isazaharadeen marked this pull request as ready for review January 27, 2025 00:03
frontend/src/pages/spotnet/defi-spring/DefiSpring.jsx Outdated Show resolved Hide resolved
frontend/babel.config.js Outdated Show resolved Hide resolved
.DS_Store Outdated Show resolved Hide resolved
web_app/telegram/README.md Outdated Show resolved Hide resolved
frontend/src/index.jsx Outdated Show resolved Hide resolved
frontend/index.html Outdated Show resolved Hide resolved
@isazaharadeen
Copy link
Contributor Author

@whateverfw all requested changes have been effected.

Copy link
Collaborator

@whateverfw whateverfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only bugs that remaining are the ones related to image imports.

frontend/src/services/wallet.jsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@whateverfw whateverfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to find a way to fix tests when adding ?react

frontend/src/services/wallet.jsx Outdated Show resolved Hide resolved
@isazaharadeen
Copy link
Contributor Author

need to find a way to fix tests when adding ?react

@whateverfw what page are you trying to access when you get this error, because it runs fine on my end. can you share the particular page or step to reproduce

@whateverfw
Copy link
Collaborator

need to find a way to fix tests when adding ?react

@whateverfw what page are you trying to access when you get this error, because it runs fine on my end. can you share the particular page or step to reproduce

form page. just connect a wallet and try to access this page, after couple of seconds it will crash
image

Copy link
Collaborator

@whateverfw whateverfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@djeck1432 djeck1432 self-requested a review January 28, 2025 15:02
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@djeck1432 djeck1432 merged commit fdfa82a into djeck1432:main Jan 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Migrate from Create React App (CRA) to Vite
3 participants