This repository has been archived by the owner on Mar 27, 2019. It is now read-only.
Add LDAP login option #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All auth methods return the same token payload, more or less. Let them all share how the access token is set.
|
Addresses #15 |
|
Nice - will take a closer look at this when we get the chance in the next few days. Thanks for contributing! |
|
Sweet! Thanks. I showed this to my team today and we voted to adopt. I can be a regular contributor if you're open to it. |
|
Most definitely @joraff!! This LGTM. Currently at re:Invent, I'll do some deeper checks later tonight and get it merged in. |
djenriquez
suggested changes
Nov 30, 2016
| @@ -70,12 +70,11 @@ export default class Login extends React.Component { | |||
| "Creds": { | |||
| "Type": this.state.loginMethodType, | |||
| "Username": this.state.username, | |||
| "password": this.state.password | |||
| "Password": this.state.password | |||
| } | |||
| }) | |||
| .then((resp) => { | |||
There was a problem hiding this comment.
We need to add an LDAP login methodtype to the login API here: https://github.com/djenriquez/vault-ui/blob/master/src/login.js#L29 because LDAP uses a different endpoint for authentication. Without this change the API will return a 400: "Invalid auth method".
| @@ -153,6 +125,24 @@ export default class Login extends React.Component { | |||
| } | |||
| } | |||
|
|
|||
| setAccessToken(resp) { | |||
djenriquez
approved these changes
Dec 1, 2016
| }; | ||
| break; | ||
| case 'ldap': | ||
| endpoint = `/v1/auth/ldap/login/${username}`; |
|
Thanks @joraff! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds LDAP as a login method option. Finishes username & password authentication, which LDAP shares some functions with. Minor refactoring.