Fixup compatibility w/ active_type gem
#232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojab
force-pushed
the
fixup_active_type
branch
2 times, most recently
from
3629b24 to
a8b733d
Compare
ojab
changed the title
active_type` gemactive_type gem
ojab
force-pushed
the
fixup_active_type
branch
10 times, most recently
from
611f384 to
a03a776
Compare
Rails switched to `sqlite3 >= 2.0` in [0], so workflow fails due to the current `~> 1.3` constraint. It's quite complicated to make current gemfiles setup to handle this, because `sqlite3` is not an AR dependency, but loaded when needed, so we need to edit all the gemfiles with explicit sqlite3 constraint. Introduce Appraisal to generate gemfiles, so it's easier to handle. [0] rails/rails@2976d37
`.const_source_location` raises `NameError` on invalid names, which means that it's either anonymous class or class name was manually defined. Skip such classes.
ojab
force-pushed
the
fixup_active_type
branch
2 times, most recently
from
3333c69 to
d183486
Compare
`ActiveType` is creating ActiveModel-like entities, but backed by ActiveRecord, mocking DB interactions [0]. Mocking is incomplete and `AbstractAdapter` is used, so `connection.table_exists?` raises `NotImplementedError`. Workaround it by using `Model#table_exists?` which also simplifies the code a bit. [0] https://github.com/makandra/active_type/blob/main/lib/active_type/no_table.rb
ojab
force-pushed
the
fixup_active_type
branch
from
d183486 to
b3e72dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle anonymous classes (a bit differently than #221) and use
.table_exists?on Model instead ofModel.connection.See commit messages for details.
This is arguable ActiveType issue, but why not handle such cases.
Also fixing compat w/ AR-main, also extracted to the separate PR #235 to allow merging separately if needed.