test: OmniAuth.config.mock_authの設定方法を変更 (#66)

以前の設定方法で複数ファイルのテストを同時に実行すると、invalidのmockが後続のテストファイルに引き継がれてテストが落ちていた

spec/requests/user_sessions_spec.rb

@@ -3,6 +3,10 @@
 require 'rails_helper'
 
 RSpec.describe 'UserSessions', type: :request do
+  before do
+    Rails.application.env_config['omniauth.auth'] = github_mock
+  end
+
   describe 'POST /create' do
     context 'with valid parameters' do
       it 'creates a new user' do
@@ -24,7 +28,7 @@
 
     context 'with invalid parameters' do
       before do
-        OmniAuth.config.mock_auth[:github] = :invalid_credentials
+        Rails.application.env_config['omniauth.auth'] = github_invalid_mock
       end
 
       it 'does not create a new user' do
@@ -48,6 +52,7 @@
   describe 'DELETE /destroy' do
     it 'removes user id from session' do
       get '/auth/github/callback'
+      expect(session[:user_id]).to be_present
       delete '/logout'
       expect(session[:user_id]).to be_nil
     end

spec/support/omniauth.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
 
-RSpec.configure do
-  OmniAuth.config.test_mode = true
+OmniAuth.config.test_mode = true
+
+def github_mock
   OmniAuth.config.mock_auth[:github] = OmniAuth::AuthHash.new({
                                                                 provider: 'github',
                                                                 uid: '123545',
@@ -11,3 +12,7 @@
                                                                 }
                                                               })
 end
+
+def github_invalid_mock
+  OmniAuth.config.mock_auth[:github] = :invalid_credentials
+end

spec/system/users_spec.rb

@@ -3,6 +3,10 @@
 require 'rails_helper'
 
 RSpec.describe 'Users', type: :system do
+  before do
+    Rails.application.env_config['omniauth.auth'] = github_mock
+  end
+
   describe 'user authentication' do
     context 'when authentication is successful' do
       it 'allows users to login' do
@@ -40,7 +44,7 @@
 
     context 'when authentication is failed' do
       before do
-        OmniAuth.config.mock_auth[:github] = :invalid_credentials
+        Rails.application.env_config['omniauth.auth'] = github_invalid_mock
       end
 
       it 'redirects to root_path' do