Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated parmest Estimator class to use experiments #2

Open
wants to merge 4 commits into
base: doe_redesign
Choose a base branch
from

Conversation

kaklise
Copy link

@kaklise kaklise commented Dec 4, 2023

Fixes # .

Summary/Motivation:

Changes proposed in this PR:

  • The updated Estimator class works with the reactor_design_with_experiments.py example
  • See TODOs at the top of the parmest_redesign.py file.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@kaklise
Copy link
Author

kaklise commented Dec 6, 2023

@dlakes94 I plan to move around some files to make it clear which examples and API are deprecated. This will create a parmest_deprecated.py file and example/_deprecated folder. parmest.py now contains the new API. There is no longer a redesign folder.

djlaky pushed a commit that referenced this pull request May 14, 2024
Parmest updates, minor code updates and docs for new API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant