-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add indentation support for set tag #621
Conversation
Thanks for this, its a great start. I will see about adding tests. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #621 +/- ##
==========================================
+ Coverage 95.54% 95.63% +0.08%
==========================================
Files 16 16
Lines 921 962 +41
Branches 253 259 +6
==========================================
+ Hits 880 920 +40
Misses 29 29
- Partials 12 13 +1
☔ View full report in Codecov by Sentry. |
@ahmetelgun I expanded this a bit more - it will now also try to clean up the value of set. I added json5 library to parse javascript style json (single or no quotes on keys and values).
I added tests in the nunjucks > test_set folder. Thanks a bunch for this! closes #287 json keys that don't require quoting in javascript will not be quoted here. Does that work in your case as well? |
looks like I accendently snuck in another change here that fixes some html tags getting formatted inside script tags. |
Thanks for your help @christopherpickering . I can't wait to use it 😃 |
🎉 This PR is included in version 1.25.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Pull Request Check List
I have a code like this. This code is not formatted very well. I tried to add support for
set
tag. I don't know how i write a test for this and i don't find a document section for this.Now, code formatted like this: