Fix: not detecting tabs as a valid seperation between tags. #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for djlint canceled.
|
ethan-vanderheijden
force-pushed
the
fix-preserve-blank-line-with-tabs
branch
from
701c70c
to
3f84651
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #812
It wasn't detecting tabs as a valid whitespace between HTML tags, causing it to transform:
<div>\n\t<p></p>\n</div>into:
<div>\n\t\n<p></p>\n</div>Notice that the transformed text has an extra new line after the tab character. Normally extra new lines are removed, but with
--preserve-blank-lines, this extra new line persists.Note:
--preserve-blank-linesand--max-blank-linesare incompatible with each other (I think this was true before my PR). Since--max-blank-linespreserves blank lines as well, it would make a lot of sense to combine the two options into one.