Skip to content

Commit

Permalink
Don't use aiohttp==3.7.0
Browse files Browse the repository at this point in the history
aio-libs/aiohttp#5110 means that https URLs
don't work.  aio-libs/aiohttp#5118 fixes the
issue, and will be included in 3.7.1.
  • Loading branch information
djmitche committed Oct 25, 2020
1 parent d47cddf commit 035960f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
5 changes: 5 additions & 0 deletions changelog/issue-3767.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
audience: users
level: patch
reference: issue 3767
---
This version adjusts the Python client requirements to avoid `aiohttp==3.7.0`, which has a [serious bug preventing use of HTTPS](https://github.com/aio-libs/aiohttp/issues/5110).
3 changes: 2 additions & 1 deletion clients/client-py/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ def run_tests(self):
raise Exception('This library does not support Python 3 versions below 3.5')
elif sys.version_info[:2] >= (3, 5):
install_requires.extend([
'aiohttp>=2.0.0',
# 3.7.0 is broken - see https://github.com/taskcluster/taskcluster/issues/3767
'aiohttp>=2.0.0,!=3.7.0',
'async_timeout>=2.0.0',
])

Expand Down
1 change: 1 addition & 0 deletions clients/client-py/tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@ extras = test
usedevelop = true

commands =
pip freeze
{envbindir}/py.test --cov-config .coveragerc --cov=taskcluster --cov-report term-missing -v {env:IG:} {env:EX1:} {env:EX2:}
./lint.sh --python "{envpython}" --flake8 "{envbindir}/flake8"

0 comments on commit 035960f

Please sign in to comment.