ENUM changes not creating migration changes for columns with a ENUM[] type

[mjeti]

say we had a table with two enum based columns where one is a enum val and one is a list.
If I change the entities in the underlying enum type, no migration statement is generated for the column with a enum list type.

test_enum: [val_1, val_2]
test_table
 column_enum        test_enum
 column_enum_list      test_enum[]

I changed the test_enum type to
test_enum: [val_1, val_2, val_3]

a migration would be generated as so

alter type "public"."test_enum" rename to "test_enum__old_version_to_be_dropped";

create type "public"."test_enum" as enum ('val_1', 'val_2', 'val_3');

alter table "public"."test_table" alter column column_enum type "public"."test_enum" using column_enum::text::"public"."test_enum";

drop type "public"."test_enum__old_version_to_be_dropped";

this will fail because it will complain about test_table.column_enum_list still using the []test_enum__old_version_to_be_dropped type.

[mjeti]

thanks @maximsmol! Any idea if this is something that can be fixed?

[maximsmol]

Sorry, didn't check GitHub notifs for a few days after going over the issues backlog.

Seems like it's not detecting the list-of-enums column as dependent on the enum's definition. Should be an easy fix if you wanna have a go at it, I'll be doing a bunch of project-wide things for a while before I get to specific issues.

[mjeti]

Cool. Could you point in a direction of where the code change would need to happen?

[gjbadros]

I think I have working fix (that at least works for my limited very similar scenario). The patch is just on the relations query of the schemainspect dependency. See:

gjbadros/schemainspect@59c7ab0

[joshainglis]

I've also got a generic array dependency handling over here (it's mixed in with handling comments also)
joshainglis/schemainspect@9d79b0d...joshainglis:schemainspect:master

As well as adding a topological sort of the table dependencies to handle tables with array types joshainglis/migra@0a9a62c...joshainglis:migra:master

[gjbadros]

Oh awesome, thanks @joshainglis -- comments is another thing on my list that I do poorly (and they matter for postgraphile lots). @djrobstep are you interested in PRs for these improvements?