-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding feature: Partial range download #29
Conversation
should ok by now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an amazing contribution @namdien177 , Thank you 💯
Thanks for fixing the documentation. Good job on figuring out how to run e2e tests, unfortunately, OneDrive doesn't offer sandbox env that I could use for running automated e2e tests so it is not easy to figure out how to run them. They are passing for me. Let me know if you have any suggestions on how to improve the project
Great job again
@namdien177 I have added you as a collaborator on a project, when you resolve the conflict you can squash and merge 👍 |
thanks. As far as I understand, the query here doesn't do anything and the PR was just for adding optional params and change the README content. Am I wrong here? If I was right then I would recommend a new PR to add the query string option to all APIs (and exclude the README changes or add a WIP tag to the option from this PR to prevent confusion). |
Glad to hear this feature will be coming soon. |
@namdien177 Fixed |
Reason and basic implementation are described in #27.
Since I am not familiar with the
request
package (tested withnode-fetch
OK ) so there might be some mistake.Also, because there is no guide to perform testing and stuff and I have tried to test it, it seems like theuploadSimple
API has some issue on the test case withparentPath
.Can you check that?
testing with E2E seems to be fine.