VW PQ: HCA mode switching #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
dkiiv
added a commit
that referenced
this pull request
May 9, 2024
* initial hca_mode flipping commit * hot fix**ing** * bump hysteresis to 5 deg * increase hysteresis to 13 degree's * change HCA flipping logic. * logic change worked, dropping hysteresis limits to test * switch to NM torque blending * temporarily bump panda maxsteer to 400 * revert panda edit, refactor torque blend * refactor, again! * try ramping the 1NM drop * bugfix for pseudo STEER_MAX? * another hotfix * change rate limit in interpolation, removed apply_driver_steer_torque_limit * throw out >3nm. switch to HCA7 when requested torque >2nm * make HCA7 switching a wider band, and add some torque interpolation * change flipping logic * fix typo * bugfix: negative steering angle * switch to hca7 based on NM rate too * change from NM rate to steeringRate * revert back to no rate based hca7 switch * up deadzone to 13 * 13 up for HCA7 worked, dropping HCA5 down to 8 * fix bug, > not < ! * bugfix: hca7 lock and unlock logic. fixed for reals now! * change delta up ramp rate when HCA7. refactor HCA switch logic a bit * added dynamic HCA7 lock behavior, based on NM and angle * tweak values for HCA mode switching
dkiiv
added a commit
that referenced
this pull request
May 14, 2024
* initial hca_mode flipping commit * hot fix**ing** * bump hysteresis to 5 deg * increase hysteresis to 13 degree's * change HCA flipping logic. * logic change worked, dropping hysteresis limits to test * switch to NM torque blending * temporarily bump panda maxsteer to 400 * revert panda edit, refactor torque blend * refactor, again! * try ramping the 1NM drop * bugfix for pseudo STEER_MAX? * another hotfix * change rate limit in interpolation, removed apply_driver_steer_torque_limit * throw out >3nm. switch to HCA7 when requested torque >2nm * make HCA7 switching a wider band, and add some torque interpolation * change flipping logic * fix typo * bugfix: negative steering angle * switch to hca7 based on NM rate too * change from NM rate to steeringRate * revert back to no rate based hca7 switch * up deadzone to 13 * 13 up for HCA7 worked, dropping HCA5 down to 8 * fix bug, > not < ! * bugfix: hca7 lock and unlock logic. fixed for reals now! * change delta up ramp rate when HCA7. refactor HCA switch logic a bit * added dynamic HCA7 lock behavior, based on NM and angle * tweak values for HCA mode switching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.