-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCA data in SPEC file #123
Comments
For sure MCA data worked at some point. but i did not encounter such files
for a long time. of course a PR is always welcome but it would be better to
first explore why it does not work for you.
…On Thu, 5 Aug 2021, 09:50 Daniel Schick, ***@***.***> wrote:
Hi @dkriegner <https://github.com/dkriegner> ,
I encountered a problem in SPEC files which contain MCA data.
For know I am trying to understand the way the MCA data is read.
I noticed that there is no special case for the @A marker which should
indicate a line of MCA data.
I think the current implementation does not assume a mixture of MCA and
usual scalar data, right?
I will draft a PR if I am a bit more into the code.
Best
Daniel
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#123>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACKZJFMXAZAKJPFRFEINJ5TT3I7ELANCNFSM5BTFKAIQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
thanks for your promt reply. As I said, the
This is true for setting the column names and the actual data which are eventually converted to the numpy array |
Hi Daniel, you are right that the parser does not explicitly detect the If the current implementation fails with newer files a PR is of course welcome. I would be glad if these existing data files could still be parsed. I think the respective unit test in |
Hi Dominik, I found some time to dive into the MCA problem. The issue actually arises again from how Sardana is implemnting the Since the Moreover the order of scalar and I made a PR which allows for both types of |
Hello, Exception occurs in |
Does the code in #129 fix the issue for you? |
Yes, I could successfully read the data from .spec file. |
Ok, I look into merging the mentioned PR and include it in a release. |
Hi @dkriegner ,
I encountered a problem in SPEC files which contain MCA data.
For know I am trying to understand the way the MCA data is read.
I noticed that there is no special case for the
@A
marker which should indicate a line of MCA data.I think the current implementation does not assume a mixture of MCA and usual scalar data, right?
I will draft a PR if I am a bit more into the code.
Best
Daniel
The text was updated successfully, but these errors were encountered: