Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy 2.0 support #185

Merged
merged 5 commits into from
Jun 5, 2024
Merged

Numpy 2.0 support #185

merged 5 commits into from
Jun 5, 2024

Conversation

dkriegner
Copy link
Owner

Enforce building with numpy-2.0 to get universal wheels.

numpy-2.0 is needed in order to create universially usable wheel files
For Python 3.8 no numpy 2.0 wheels are available and it will be end of
life in few month. It is nevertheless still supported if one builds from
source
@dkriegner
Copy link
Owner Author

I could imagine that the changes of pyproject.toml annoy packagers. @picca: do you have any comment or suggestion for this? Or will you just patch it out on Debian anyways?

I am still gonna test this with Gentoo ebuilds and report back here.

@picca
Copy link

picca commented May 22, 2024 via email

@dkriegner
Copy link
Owner Author

The package works seems to work with both numpy 1.x and numpy 2.x. But to get wheel files for PyPI these wheels have to be built using numpy 2.x since they otherwise won't work with both numpy versions. What I use in pyproject.toml is what is explicitly recommended by numpy.

I believe Debian can likely remove this numpy-2.0 dependency for the build system.
If I would know a way to introduce this build requirement only for the cibuildwheel pipeline on Azure this might be a better option but the way it's now protects the users from breaking their xrayutilities installation if they update numpy.

@picca
Copy link

picca commented May 22, 2024 via email

@dkriegner
Copy link
Owner Author

With Gentoo ebuilds this seems to still work just fine since they seem to ignore the dependencies in pyproject.toml in favor of looking the ones defined in the ebuild. merging

@dkriegner dkriegner merged commit 91bdf89 into main Jun 5, 2024
14 checks passed
@dkriegner dkriegner deleted the numpy20 branch June 5, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants