Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editing writing style and punctuation #1

Merged
merged 18 commits into from
Feb 16, 2022
Merged

editing writing style and punctuation #1

merged 18 commits into from
Feb 16, 2022

Conversation

deerskindoll
Copy link

No description provided.

@deerskindoll
editing writing style and punctuation
e6e931c 
Signed-off-by: Jana Vrbkova <jvrbkova@redhat.com>
deerskindoll and others added 2 commits February 16, 2022 10:54
@deerskindoll @ibuziuk
Update _posts/2022-02-16-reviewing-pull-requests.adoc
c2d79e9 
Co-authored-by: Ilya Buziuk <ilyabuziuk@gmail.com>
@deerskindoll @ibuziuk
Update _posts/2022-02-16-reviewing-pull-requests.adoc
14a7607 
Co-authored-by: Ilya Buziuk <ilyabuziuk@gmail.com>
deerskindoll and others added 2 commits February 16, 2022 11:12
@deerskindoll @ibuziuk
Update _posts/2022-02-16-reviewing-pull-requests.adoc
a66d8e7 
Co-authored-by: Ilya Buziuk <ilyabuziuk@gmail.com>
@deerskindoll @ibuziuk
Update _posts/2022-02-16-reviewing-pull-requests.adoc
f0a0ada 
Co-authored-by: Ilya Buziuk <ilyabuziuk@gmail.com>
ibuziuk
ibuziuk approved these changes Feb 16, 2022
View reviewed changes
Copy link

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great job 👍

@deerskindoll
Copy link
Author

Thank you, great job +1

I'm happy you like it, it was a fun article to edit.

@themr0c
Copy link

themr0c commented Feb 16, 2022

@dkwon17 You are the only one with the ability to approve the running workflows and merge this pull.

dkwon17
dkwon17 reviewed Feb 16, 2022
View reviewed changes
_posts/2022-02-16-reviewing-pull-requests.adoc Outdated

* <<../../01/11/@ilya.buziuk-contributing-for-the-first-time-to-a-project#set-up-project,How can maintainers set up their projects to use Eclipse Che?>>
* link:https://www.eclipse.org/che/docs/che-7/end-user-guide/authoring-devfiles-version-2[Authoring a devfile v2]

NOTE: It is crucial that your project contains a well-defined devfile.yaml file to make the most out of your development experience with {prod}. The devfile should define your project's development environment such as development commands, containers, endpoints etc.
NOTE: Your project must contain a well-defined devfile.yaml file to make the most out of your development experience with {prod}. Use the devfile to define your project’s development environment such as development commands, containers, endpoints, etc.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NOTE: Your project must contain a well-defined devfile.yaml file to make the most out of your development experience with {prod}. Use the devfile to define your project’s development environment such as development commands, containers, endpoints, etc.
NOTE: Your project must contain a well-defined devfile.yaml file to make the most out of your development experience with {prod}. Use the devfile to define your project's development environment such as development commands, containers, endpoints, etc.

dkwon17
dkwon17 reviewed Feb 16, 2022
View reviewed changes
_posts/2022-02-16-reviewing-pull-requests.adoc Outdated

=== Launching a workspace and reviewing the PR
image::/assets/img/reviewing-pull-requests/ide.png[The Che-theia editor]
Figure 3: The Che-Theia editor.

Once the workspace has launched and the Web IDE has opened, you will see that the project has been cloned already (see the Explorer view on the bottom-right).
After you launch the workspace, the web IDE will open automatically and you'll see that the project has been cloned already (see the Explorer view on the bottom-right).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
After you launch the workspace, the web IDE will open automatically and you'll see that the project has been cloned already (see the Explorer view on the bottom-right).
After you launch the workspace, the web IDE will open automatically and you'll see that the project has been cloned already (see the Explorer view on the left-hand side).

@dkwon17
Copy link
Owner

dkwon17 commented Feb 16, 2022

Thank you for the reviews @deerskindoll , @themr0c , I've made some suggestions.

@dkwon17
Copy link
Owner

dkwon17 commented Feb 16, 2022

@deerskindoll @themr0c is it okay if I commit the suggestions myself?

@deerskindoll @themr0c
Update _posts/2022-02-16-reviewing-pull-requests.adoc
8c2087f 
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
deerskindoll and others added 12 commits February 16, 2022 16:15
@deerskindoll @themr0c
Update _posts/2022-02-16-reviewing-pull-requests.adoc
a0d777c 
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@deerskindoll @themr0c
Update _posts/2022-02-16-reviewing-pull-requests.adoc
09d37b7 
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@deerskindoll @dkwon17
Update _posts/2022-02-16-reviewing-pull-requests.adoc
5be850a 
Co-authored-by: David Kwon <83611742+dkwon17@users.noreply.github.com>
@deerskindoll @themr0c
Update _posts/2022-02-16-reviewing-pull-requests.adoc
6f220f0 
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@deerskindoll @themr0c
Update _posts/2022-02-16-reviewing-pull-requests.adoc
d70d467 
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@deerskindoll @themr0c
Update _posts/2022-02-16-reviewing-pull-requests.adoc
1952a02 
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@deerskindoll @themr0c
Update _posts/2022-02-16-reviewing-pull-requests.adoc
de54e5e 
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@deerskindoll @themr0c
Update _posts/2022-02-16-reviewing-pull-requests.adoc
27f96a7 
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@deerskindoll @themr0c
Update _posts/2022-02-16-reviewing-pull-requests.adoc
83be8bc 
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@deerskindoll @themr0c
Update _posts/2022-02-16-reviewing-pull-requests.adoc
c75941a 
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@deerskindoll @themr0c
Update _posts/2022-02-16-reviewing-pull-requests.adoc
167a85d 
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@deerskindoll
Update 2022-02-16-reviewing-pull-requests.adoc
6e3ff04 
quick typo fix
@dkwon17
Copy link
Owner

dkwon17 commented Feb 16, 2022

Thank you everyone, merging now

@dkwon17 dkwon17 merged commit 679b42a into dkwon17:reviewing-pull-requests Feb 16, 2022
dkwon17 added a commit that referenced this pull request Feb 16, 2022
@deerskindoll @ibuziuk
@themr0c @dkwon17
editing writing style and punctuation (#1)
3e3319e 
* editing writing style and punctuation

Signed-off-by: Jana Vrbkova <jvrbkova@redhat.com>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Ilya Buziuk <ilyabuziuk@gmail.com>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Ilya Buziuk <ilyabuziuk@gmail.com>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Ilya Buziuk <ilyabuziuk@gmail.com>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Ilya Buziuk <ilyabuziuk@gmail.com>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: David Kwon <dakwon@redhat.com>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>

* Update _posts/2022-02-16-reviewing-pull-requests.adoc

Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>

* Update 2022-02-16-reviewing-pull-requests.adoc

quick typo fix

Co-authored-by: Ilya Buziuk <ilyabuziuk@gmail.com>
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Co-authored-by: David Kwon <dakwon@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkwon17 dkwon17 dkwon17 left review comments

@themr0c themr0c themr0c left review comments

@ibuziuk ibuziuk ibuziuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deerskindoll @themr0c @dkwon17 @ibuziuk