Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: Uninstall #8

Merged
merged 4 commits into from
Apr 25, 2022
Merged

review: Uninstall #8

merged 4 commits into from
Apr 25, 2022

Conversation

max-cx
Copy link

@max-cx max-cx commented Apr 23, 2022

What does this pull request change?

Review of eclipse-che#2281

What issues does this pull request fix or reference?

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@max-cx
Copy link
Author

max-cx commented Apr 23, 2022

@dkwon17, are there CLI procedures for uninstalling the DevWorkspace Operator and the Eclipse Che Operator?

If there is no CLI procedure for uninstalling the Eclipse Che Operator, then I suggest removing the section Uninstalling Che by using the OpenShift CLI completely (otherwise, we're missing a description of removing the Eclipse Che Operator when performing the procedure for Uninstalling Che by using the OpenShift CLI). What do you think, can we drop Uninstalling Che by using the OpenShift CLI? If you agree, ping me and I'll remove it and rearrange the docs while I still have my PR branch.

@dkwon17 dkwon17 merged commit 328dc90 into dkwon17:uninstall Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants