Always curly #928
Merged
Always curly #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebFreak001
requested changes
Sep 1, 2023
|
can you also auto-format the code with dfmt (default settings or so)? |
WebFreak001
reviewed
Sep 4, 2023
burner
commented
Sep 5, 2023
WebFreak001
reviewed
Sep 5, 2023
|
@WebFreak001 anything else you want me to do on this? |
WebFreak001
reviewed
Sep 14, 2023
burner
force-pushed
the
always_curly
branch
from
7172e5c
to
237038f
Compare
Check that if|else|for|foreach|while|do|try|catch
are always followed by a BlockStatement aka. { }
closer
can not get the test to work
try to get the AutoFix in place
maybe a fix
nicer messages
some formatting
more tinkering
still nothing
autofix work now
AutoFix name
message to message_postfix
burner
force-pushed
the
always_curly
branch
from
237038f
to
8c577d7
Compare
WebFreak001
approved these changes
Sep 24, 2023
|
@WebFreak001 thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check to always require BlockStatements after if|for|foreach|while|do|catch|try|finally